Use pagenation on getting assets in get_normalized_balances.#30
Draft
cryptcoin-junkey wants to merge 1 commit intomonaparty-developfrom
Draft
Use pagenation on getting assets in get_normalized_balances.#30cryptcoin-junkey wants to merge 1 commit intomonaparty-developfrom
cryptcoin-junkey wants to merge 1 commit intomonaparty-developfrom
Conversation
Signed-off-by: Cryptcoin Junkey <cryptcoin.junkey@gmail.com>
Member
Author
After applied this patch, we can get all (more than 1000) balances that Monapa-chan has. |
Codecov Report
@@ Coverage Diff @@
## monaparty-develop #30 +/- ##
====================================================
- Coverage 3.95% 3.94% -0.01%
====================================================
Files 30 30
Lines 3973 3981 +8
====================================================
Hits 157 157
- Misses 3816 3824 +8
Continue to review full report at Codecov.
|
|
どうしても気になってしまったためコメントで失礼します。 |
Member
Author
|
@anipopina ご指摘はそのとおりなのですが、#29 でのコメントの通り、それなりの規模で書き換える前提で作業にはいっており、現時点では最適化は考慮していません。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cryptcoin Junkey cryptcoin.junkey@gmail.com
fixes #29